Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host/hs_log: Amend doxygen comments in the header file #1689

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

wpiet
Copy link
Contributor

@wpiet wpiet commented Feb 7, 2024

Adds missing macro documentation (BLE_NPL_LOG_MODULE). Adds minor formatting improvements.


#ifndef BLE_NPL_LOG_MODULE
/** Defines the logging module for NimBLE Porting Layer (NPL). */
#define BLE_NPL_LOG_MODULE BLE_HS_LOG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, forgot about this

this needs to be defined before #include <nimble/nimble_npl_log.h>

Copy link
Contributor

@sjanc sjanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLE_NPL_LOG_MODULE must be define before nimble_npl_log.h is included

Adds missing macro documentation (BLE_NPL_LOG_MODULE).
Adds minor formatting improvements.
@sjanc sjanc merged commit ae9273d into apache:master Feb 14, 2024
16 checks passed
@wpiet wpiet deleted the log-doc branch February 14, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants