Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimble/controller: Enable LL encryption if BLE_LL_ISO_BROADCASTER #1705

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

MariuszSkamra
Copy link
Contributor

To support encrypting/decrypting broadcasts, LL Encryption shall be enabled by BLE_LL_ISO_BROADCASTER.

To support encrypting/decrypting broadcasts, LL Encryption shall be
enabled by BLE_LL_ISO_BROADCASTER.
@MariuszSkamra
Copy link
Contributor Author

@andrzej-kaczmarek Please take a look

Copy link
Contributor

@rymanluk rymanluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it does not build without this flag it makes sens to set it.
However, I can imagine broadcaster using no encryption and would like to not waste memory for that.

Suggest to create an issue to allow Broadcaster without encryption.

For now this LGTM

@rymanluk rymanluk merged commit 23eec0a into apache:master Feb 26, 2024
17 checks passed
@MariuszSkamra MariuszSkamra deleted the fix_bcst_encr branch February 26, 2024 14:20
@MariuszSkamra
Copy link
Contributor Author

Suggest to create an issue to allow Broadcaster without encryption.

Done, #1713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants