Adding port forward to OKE Pod #8014
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhorvath
added
LSP
sdedic
reviewed
Dec 11, 2024
| .withName(name) | ||
| .get(); | ||
| if (deployment == null) { | ||
| continue; |
There was a problem hiding this comment.
no log / failed (ignored) result to the caller ?
| @@ -67,8 +64,8 @@ static void runWithClient(ClusterItem cluster, Consumer<KubernetesClient> consum | |||
| Config config = prepareConfig(cluster.getConfig(), cluster); | |||
| try (KubernetesClient client = new KubernetesClientBuilder().withConfig(config).build();) { | |||
| consumer.accept(client); | |||
| } catch (Exception e) { | |||
| Exceptions.printStackTrace(e); | |||
| } catch (Throwable t) { | |||
| */ | ||
| public void startPortForward(PodItem podItem) { | ||
| if (activePortForwards.containsKey(podItem.getName())) { | ||
| NotificationUtils.showMessage("Port forwarding already active for: " + podItem.getName()); |
| List<PortForwardItem> forwardItems = new ArrayList<>(); | ||
| List<PortForward> forwards = new ArrayList<>(); | ||
| if (ports.isEmpty()) { | ||
| NotificationUtils.showMessage("No ports found for pod: " + podItem.getName()); |
| Pod pod = client.pods().inNamespace(podItem.getNamespace()).withName(podItem.getName()).get(); | ||
|
|
||
| if (pod == null) { | ||
| System.out.println("Pod not found: " + podItem.getName()); |
There was a problem hiding this comment.
Log or NotificationUtils.showMessage ?
| NotificationUtils.showMessage(Bundle.ForwardingPorts(port.toString(), podItem.getName())); | ||
| } | ||
| latches.put(podItem.getName(), latch); | ||
| List<PortForwardItem> oldValue = activePortForwards.put(podItem.getName(), forwardItems); |
There was a problem hiding this comment.
The old value does not make much sense: even if old value is later restored, its latch is lost for good.
| activePortForwards.remove(podItem.getName()); | ||
| firePropertyChange(podItem, forwardItems, oldValue); | ||
| } catch (InterruptedException | IOException ex) { | ||
| Exceptions.printStackTrace(ex); |
There was a problem hiding this comment.
Shouldn't this error notification be presented to the user somehow ?
| @@ -188,8 +197,18 @@ private void runInCluster() { | |||
| .create(); | |||
| } | |||
| }); | |||
| } catch(Throwable t) { | |||
|
|
||
| InputOutputProvider<?, ?, ?, ?> newSpiDef | ||
| = Lookup.getDefault().lookup(InputOutputProvider.class); | ||
| Object io = newSpiDef.getIO("test io", true, Lookup.EMPTY); |
There was a problem hiding this comment.
This seems as an unfinished implementation ?
| @@ -87,5 +86,10 @@ public static ChildrenProvider.SessionAware<CompartmentItem, ClusterItem> getClu | |||
| .collect(Collectors.toList()); | |||
| }; | |||
| } | |||
|
|
|||
| @Override | |||
jhorvath
force-pushed
the
oci-port-forward
branch
from
d58dfb9 to
9d2e3c1
Compare
|
-1 to further changes here pending resolution of concerns in #7826 (comment) as it might conflict. Might have limited time for NetBeans in coming weeks, so adding a note that I'm happy for @matthiasblaesing or @mbien to remove this -1 and the do-not-merge label as and when they're happy with resolution. |
neilcsmith-net
added
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding port forward command to the Oracle Cloud Assets