Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NUTCH-3094 Github tests to run if build configuration changes #841

Merged
merged 1 commit into from
Dec 3, 2024
Merged

NUTCH-3094 Github tests to run if build configuration changes #841

merged 1 commit into from
Dec 3, 2024

Conversation

sebastian-nagel
Copy link
Contributor

This PR improves the logic of conditional steps in the Github workflow:

  • all tests are executed if any of build configuration, core or plugins code changed
  • core tests if there are only changes in core
  • plugin tests if there are only changes in the plugins source folder

@sebastian-nagel
Copy link
Contributor Author

Ok, this didn't work as expected: all tests were run although there were no changes in build configuration or source code. Need to improve the PR...

lewismc
lewismc approved these changes Dec 1, 2024
View reviewed changes
Copy link
Member

@lewismc lewismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
We could possibly extend this further to run dependency-related targets if any ivy configuration changes but that is outside the scope.
Nice patch

@sebastian-nagel sebastian-nagel merged commit 68c1a7d into apache:master Dec 3, 2024
4 checks passed
@sebastian-nagel sebastian-nagel deleted the NUTCH-3094 branch December 3, 2024 11:19
@sebastian-nagel sebastian-nagel mentioned this pull request Dec 3, 2024
Merged
@sebastian-nagel sebastian-nagel restored the NUTCH-3094 branch December 3, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewismc lewismc lewismc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastian-nagel @lewismc