Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a deadlock #15323

Merged
merged 1 commit into from
Dec 25, 2024
Merged

fix a deadlock #15323

merged 1 commit into from
Dec 25, 2024

Conversation

hujun260
Copy link
Contributor

Summary

fix regresion from #15301
image

Impact

uart_pl011

Testing

qemu-armv8a:nsh_smp

@github-actions github-actions bot added Area: Drivers Drivers issues Size: XS The size of the change in this PR is very small labels Dec 24, 2024
yamt
yamt reviewed Dec 24, 2024
View reviewed changes
drivers/serial/uart_pl011.c Outdated Show resolved Hide resolved
@github-actions github-actions bot added Area: OS Components OS Components issues Size: M The size of the change in this PR is medium and removed Size: XS The size of the change in this PR is very small labels Dec 25, 2024
@nuttxpr
Copy link

nuttxpr commented Dec 25, 2024

[Experimental Bot, please feedback here]

No, this PR does not fully meet the NuttX requirements. While it identifies the issue it fixes, it lacks crucial details.

Here's what's missing:

  • Summary: Needs a clear explanation of what the regression was (what functionality was broken), what part of the code was changed to fix it, and how the fix works. The screenshot provides a visual hint, but it's not a substitute for a textual explanation.
  • Impact: The sections under "Impact" are incomplete. It simply states "uart_pl011," which isn't helpful. All "NO" / "YES" questions need to be answered, and descriptions provided where necessary. Even if the impact is minimal, it needs to be explicitly stated (e.g., "Impact on user: NO").
  • Testing: While it mentions the target platform (qemu-armv8a:nsh_smp), it lacks critical information about the build host and, most importantly, the testing logs before and after the change. These logs are crucial to demonstrate that the change fixes the reported issue and doesn't introduce new problems.

The PR needs to be significantly expanded to meet the NuttX requirements.

@hujun260
fix a deadlock
19b76b9 
0  up_testset (lock=0x404241c0 <g_uart1priv+32>) at /home/hujun5/下载/vela_sim/nuttx/include/arch/spinlock.h:96
1  spin_lock_wo_note (lock=<optimized out>) at /home/hujun5/下载/vela_sim/nuttx/include/nuttx/spinlock.h:207
2  spin_lock_irqsave_wo_note (lock=0x404241c0 <g_uart1priv+32>) at /home/hujun5/下载/vela_sim/nuttx/include/nuttx/spinlock.h:467
3  spin_lock_irqsave (lock=0x404241c0 <g_uart1priv+32>) at /home/hujun5/下载/vela_sim/nuttx/include/nuttx/spinlock.h:521
4  pl011_txint (dev=0x404240b0 <g_uart1port>, enable=false) at serial/uart_pl011.c:746
5  0x00000000402a3f1c in uart_xmitchars (dev=0x404240b0 <g_uart1port>) at serial/serial_io.c:118
6  0x00000000402a10f8 in pl011_txint (dev=<optimized out>, enable=<optimized out>) at serial/uart_pl011.c:756
7  0x00000000402a2ca0 in uart_write (filep=<optimized out>, buffer=<optimized out>, buflen=0) at serial/serial.c:1493
8  0x000000004028c464 in file_writev_compat (filep=0x4046cda0, uio=<optimized out>) at vfs/fs_write.c:81
9  0x000000004028c588 in file_writev (filep=<optimized out>, uio=uio@entry=0x40470dc0) at vfs/fs_write.c:161
10 0x000000004028c5fc in nx_writev (fd=<optimized out>, iov=iov@entry=0x40470e10, iovcnt=iovcnt@entry=1) at vfs/fs_write.c:257
11 0x000000004028c660 in writev (fd=<optimized out>, iov=iov@entry=0x40470e10, iovcnt=iovcnt@entry=1) at vfs/fs_write.c:356
12 0x000000004028c6dc in write (fd=<optimized out>, buf=buf@entry=0x404090b2 <g_nshgreeting>, nbytes=<optimized out>) at vfs/fs_write.c:421
13 0x00000000402adb10 in nsh_session (pstate=pstate@entry=0x40471080, login=login@entry=1, argc=argc@entry=1, argv=argv@entry=0x4046cf40) at nsh_session.c:108
14 0x00000000402ad94c in nsh_consolemain (argc=argc@entry=1, argv=argv@entry=0x4046cf40) at nsh_consolemain.c:75
15 0x00000000402ad894 in nsh_main (argc=argc@entry=1, argv=argv@entry=0x4046cf40) at nsh_main.c:74
16 0x00000000402a5880 in nxtask_startup (entrypt=0x402ad7fc <nsh_main>, argc=1, argv=0x4046cf40) at sched/task_startup.c:72
17 0x000000004029d444 in nxtask_start () at task/task_start.c:116
18 0x0000000000000000 in ?? ()

fix regresion from apache#15301

Signed-off-by: hujun5 <[email protected]>
@github-actions github-actions bot added Size: XS The size of the change in this PR is very small and removed Area: OS Components OS Components issues Size: M The size of the change in this PR is medium labels Dec 25, 2024
@acassis acassis merged commit 233e175 into apache:master Dec 25, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 left review comments

@yamt yamt yamt left review comments

@acassis acassis acassis approved these changes

Assignees
No one assigned
Labels
Area: Drivers Drivers issues Size: XS The size of the change in this PR is very small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hujun260 @nuttxpr @acassis @yamt @xiaoxiang781216