Skip to content

Commit

Permalink
refactor: Remove cucumber based test in python (#3253)
Browse files Browse the repository at this point in the history
* test(bindings/python): Remove cucumber based test

1. Remove tests based on `behave` library.
2. Update related documentations.

* fix(bindings/python): Enable memory test in workflow.
  • Loading branch information
laipz8200 authored Oct 10, 2023
1 parent 11fb1e1 commit f3317d6
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 106 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/bindings_python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,10 @@ jobs:
python -m pip install -e .[test]
- name: Run behave
working-directory: "bindings/python"
env:
OPENDAL_MEMORY_TEST: on
run: |
python -m behave tests
pytest -vk TestMemory
linux:
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions bindings/python/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,11 @@ Note: `maturin develop` will be faster, but doesn't support all the features. In

## Test

OpenDAL adopts `behave` for behavior tests:
OpenDAL adopts `pytest` for behavior tests:

```shell
maturin develop -E test
behave tests
OPENDAL_MEMORY_TEST=on pytest -vk TestMemory
```

## Docs
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ Run some tests:

```shell
maturin develop -E test
behave tests
OPENDAL_MEMORY_TEST=on pytest -vk TestMemory
```

Build API docs:
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ benchmark = [
"boto3-stubs[essential]",
]
docs = ["pdoc"]
test = ["behave", "pytest", "python-dotenv"]
test = ["pytest", "python-dotenv"]

[project.urls]
Documentation = "https://opendal.apache.org/docs/python/opendal.html"
Expand Down
1 change: 0 additions & 1 deletion bindings/python/tests/binding.feature

This file was deleted.

100 changes: 0 additions & 100 deletions bindings/python/tests/steps/binding.py

This file was deleted.

0 comments on commit f3317d6

Please sign in to comment.