Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindings/c: Make sure API is consistent by removing blocking #3281

Closed
Xuanwo opened this issue Oct 14, 2023 · 2 comments
Closed

bindings/c: Make sure API is consistent by removing blocking #3281

Xuanwo opened this issue Oct 14, 2023 · 2 comments
Labels
bindings/c

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Oct 14, 2023 

          I found an issue that our naming for structs and functions is inconsistent. The word `blocking` shown up randomly.

cc @Ji-Xinyou, how about removing all blocking from our API for now? We can add async version in the future.

Originally posted by @Xuanwo in #3259 (comment)
@xyjixyjixyji
Copy link
Contributor

I will take a look right now 😆

@xyjixyjixyji xyjixyjixyji mentioned this issue Oct 14, 2023
Merged
@xyjixyjixyji
Copy link
Contributor

Solved #3282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bindings/c
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Xuanwo @tisonkun @xyjixyjixyji