-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(bindings/C): Alter naming convention for consistency #3282
Conversation
Relate #3281 |
Oh, I notice this probably could break the swift, go and zig as well, @Xuanwo . Would you please take a look at that when you got time? |
BTW c binding is used by other language bindings, does it ready to release? 🤔 |
Hmm I think the major functionalities are already there, There are a couple of things to consider
If the answer to the second question is yes, we may need to start figuring out what we are missing. In any way this needs some discussions, but it is good to mention this issue up since we do need to make a release soon 🤣 |
blocking
from API names for consistencyblocking
from API names for consistency
For now, YES. For always, I don't know either. It depends on the future development of OpenDAL. Pin exact tags of C binding for other binding is complex and makes the development work much harder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm willing to help address the issues for zig/go/swift. However, I would prefer to address the following comments first:
This is a breaking change, it's better to record it in C binding's |
I will address these issues later today. Thanks for the review. |
Looking forward to the API stabilizing, so that I can continue with the integration work of Milvus. 😄 |
I believe this PR will address most of the API flavor issues. |
This seems to be a PR that is related to many things, I will mark this as draft and make this ready for review after some polishments. |
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
cc @Ji-Xinyou, would you like to take a review? Thanks! |
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
cc @jiaoew1991, I have added an |
Signed-off-by: Xuanwo <[email protected]>
blocking
from API names for consistencySigned-off-by: Xuanwo <[email protected]>
Added commits look perfect to me. |
cc @Ji-Xinyou, do you think this PR is good to go? |
Signed-off-by: Xuanwo <[email protected]>
Yes, I think this PR is ready :) |
We remove
blocking
for consistency and will add async support in the future, where we will add async keyword to the API.This PR also rename the
opendal_reader_read()
first argument fromself
toreader
, sinceself
is not a C convention.