Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(services/webdav): migrate to test planner for webdav #3379

Merged
merged 16 commits into from
Nov 2, 2023

Conversation

shauvet
Copy link
Contributor

@shauvet shauvet commented Oct 25, 2023

related with #3267

fixtures/nextcloud/docker-compose.yml Outdated Show resolved Hide resolved
fixtures/owncloud/docker-compose.yml Outdated Show resolved Hide resolved
@Zheaoli
Copy link
Member

Zheaoli commented Oct 26, 2023

I will review this PR,cc @Xuanwo

.github/services/webdav/nginx/action.yml Outdated Show resolved Hide resolved
.github/services/webdav/nginx_with_password/action.yml Outdated Show resolved Hide resolved
fixtures/nextcloud/docker-compose.yml Outdated Show resolved Hide resolved
fixtures/owncloud/docker-compose.yml Outdated Show resolved Hide resolved
@shauvet shauvet marked this pull request as ready for review October 27, 2023 12:51
@shauvet shauvet requested a review from PsiACE as a code owner October 27, 2023 12:51
Copy link
Member

@Zheaoli Zheaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc @Xuanwo

@Zheaoli
Copy link
Member

Zheaoli commented Oct 31, 2023

Please squash the commit

BTW plz use git pull --rebase when you update from the upstream

@suyanhanx
Copy link
Member

Please squash the commit

We don't ask for this.

@Xuanwo
Copy link
Member

Xuanwo commented Oct 31, 2023

I'm not sure if this error related to #3429

>       operator.write(filename, content)
E       opendal.Error: Unexpected (temporary) at write, context: { url: http://127.0.0.1:8080/remote.php/webdav//, called: http_util::Client::send_async, service: webdav, path: random_file_722b4c6d-b06e-49e1-a9d6-10c311f50e68 } => send async request, source: error sending request for url

@Zheaoli
Copy link
Member

Zheaoli commented Nov 1, 2023

you can take a look at #3448, add health check for docker compose would better

@shauvet
Copy link
Contributor Author

shauvet commented Nov 1, 2023

you can take a look at #3448, add health check for docker compose would better

I've added the health check for nextcloud and owncloud. But it still cannot check pass, I'm not sure the reason.

@Zheaoli
Copy link
Member

Zheaoli commented Nov 1, 2023

@shauvet Would you mind I modify some code on your PR?

@shauvet
Copy link
Contributor Author

shauvet commented Nov 1, 2023

@shauvet Would you mind I modify some code on your PR?

I don't mind. Please.

@Zheaoli
Copy link
Member

Zheaoli commented Nov 1, 2023

@Xuanwo @shauvet the test has been passed, the PR is ready to merge

Copy link
Member

@Zheaoli Zheaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xuanwo
Copy link
Member

Xuanwo commented Nov 2, 2023

Thanks a lot!

@Xuanwo Xuanwo merged commit 9bcb834 into apache:main Nov 2, 2023
24 checks passed
@shauvet shauvet deleted the test-webdav branch November 2, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants