Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nodejs test adapt OPENDAL_DISABLE_RANDOM_ROOT #3456

Merged
merged 7 commits into from
Nov 1, 2023

Conversation

suyanhanx
Copy link
Member

@suyanhanx suyanhanx commented Nov 1, 2023

close #3452

bindings/nodejs/tests/utils.mjs Outdated Show resolved Hide resolved
bindings/nodejs/tests/utils.mjs Outdated Show resolved Hide resolved
Signed-off-by: suyanhanx <[email protected]>
Signed-off-by: suyanhanx <[email protected]>
Signed-off-by: suyanhanx <[email protected]>
Signed-off-by: suyanhanx <[email protected]>
@suyanhanx suyanhanx force-pushed the random-root-nodejs-test branch from 151c32b to 13daaee Compare November 1, 2023 12:25
Signed-off-by: suyanhanx <[email protected]>
@suyanhanx suyanhanx force-pushed the random-root-nodejs-test branch from 13daaee to 9d6f99a Compare November 1, 2023 12:51
Signed-off-by: suyanhanx <[email protected]>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo marked this pull request as ready for review November 1, 2023 13:50
@Xuanwo Xuanwo requested a review from PsiACE as a code owner November 1, 2023 13:50
@Xuanwo Xuanwo merged commit 6e44078 into main Nov 1, 2023
129 of 146 checks passed
@Xuanwo Xuanwo deleted the random-root-nodejs-test branch November 1, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bindings/nodejs: Add OPENDAL_DISABLE_RANDOM_ROOT support for behavior testing
2 participants