Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Make every components seperate, remove workspace #4134

Merged
merged 10 commits into from
Feb 4, 2024
Merged

chore: Make every components seperate, remove workspace #4134

merged 10 commits into from
Feb 4, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Feb 2, 2024 •
edited
Loading

Follow #4126

Remaining work:

  • Make workflow seperate too

@github-actions github-actions bot requested review from G-XD and morristai February 2, 2024 16:19
@Xuanwo Xuanwo marked this pull request as draft February 2, 2024 16:19
Xuanwo added 5 commits February 3, 2024 00:35
@Xuanwo
Fix CI
bbb0f57 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix workflow core
4e94203 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
FIx website
70c272e 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Clean job name
8cc7ee7 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Use 0.5.5
de11e2f 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo marked this pull request as ready for review February 2, 2024 16:50
@suyanhanx
Copy link
Member

Why do we delete those components' lock file?

tisonkun
tisonkun requested changes Feb 3, 2024
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll review this patch in a few days. Please wait a bit :D

@Xuanwo
Copy link
Member Author

Xuanwo commented Feb 3, 2024

Why do we delete those components' lock file?

lock files for bindings is not useful, they either have their own lock file or just used in build.

tisonkun
tisonkun reviewed Feb 3, 2024
View reviewed changes
bindings/java/Cargo.toml Outdated Show resolved Hide resolved
@Xuanwo
Fix ci
54ab0b1 
Signed-off-by: Xuanwo <[email protected]>
This was referenced Feb 3, 2024
Merged
Merged
@Xuanwo
Copy link
Member Author

Xuanwo commented Feb 3, 2024

cc @tisonkun TPAL.

@Xuanwo Xuanwo merged commit 0f316b4 into main Feb 4, 2024
235 checks passed
@Xuanwo Xuanwo deleted the remove-workspace branch February 4, 2024 00:20
@tisonkun
Copy link
Member

tisonkun commented Feb 4, 2024 •
edited
Loading

I found a new issue that some meta files may not be respected:

  • rust-toolchain.toml
  • rustfmt.toml
  • deny.toml

... when run cargo xxx for a specific package now; due to the change of folder structure?

This was referenced Feb 4, 2024
Closed
Closed
@Xuanwo Xuanwo mentioned this pull request Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@messense messense Awaiting requested review from messense messense is a code owner

@Zheaoli Zheaoli Awaiting requested review from Zheaoli Zheaoli is a code owner

@suyanhanx suyanhanx Awaiting requested review from suyanhanx suyanhanx is a code owner

@oowl oowl Awaiting requested review from oowl oowl is a code owner

@silver-ymz silver-ymz Awaiting requested review from silver-ymz silver-ymz is a code owner

@xyjixyjixyji xyjixyjixyji Awaiting requested review from xyjixyjixyji

@G-XD G-XD Awaiting requested review from G-XD

@morristai morristai Awaiting requested review from morristai

Assignees
No one assigned
Labels
releases-note/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xuanwo @suyanhanx @tisonkun