feat(integrations/object_store): add AmazonS3Builder #5456
+122
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorgan
force-pushed
the
object_store_options
branch
from
eb177ef to
d9c2049
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5190
Rationale for this change
What changes are included in this PR?
Add
AmazonS3Builder, similar toobject_store::aws::AmazonS3Builder, so users can use it to build anOpendalStoredirectly. This eliminates the need for users to understand concepts likeoperator,S3inOpenDALAre there any user-facing changes?
Yes, after adding this new feature, users can use the new API. I'll update the document later.