Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Upgrade and fix typos #5468

Merged
merged 2 commits into from
Dec 27, 2024
Merged

ci: Upgrade and fix typos #5468

merged 2 commits into from
Dec 27, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 27, 2024

Which issue does this PR close?

Closes #5373

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Signed-off-by: Xuanwo <[email protected]>
Copy link

codspeed-hq bot commented Dec 27, 2024

CodSpeed Performance Report

Merging #5468 will degrade performances by 15.89%

Comparing fix-typos (a0f014e) with main (32fc3c5)

Summary

⚡ 8 improvements
❌ 4 regressions
✅ 61 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-typos Change
buffer 256 KiB * 32 chunk 154.4 ns 183.6 ns -15.89%
buffer 256 KiB * 4 chunk 154.4 ns 183.6 ns -15.89%
buffer 4.00 MiB * 32 chunk 154.4 ns 183.6 ns -15.89%
buffer 4.00 MiB * 4 chunk 154.4 ns 183.6 ns -15.89%
256 KiB * 1000k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 1000k truncate 245.8 ns 216.7 ns +13.46%
256 KiB * 100k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 100k truncate 245.8 ns 216.7 ns +13.46%
256 KiB * 10k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 10k truncate 245.8 ns 216.7 ns +13.46%
256 KiB * 1k chunk 212.8 ns 183.6 ns +15.89%
256 KiB * 1k truncate 245.8 ns 216.7 ns +13.46%

Copy link
Member

@Zheaoli Zheaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zheaoli Zheaoli merged commit 86d6c42 into main Dec 27, 2024
276 of 277 checks passed
@Zheaoli Zheaoli deleted the fix-typos branch December 27, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants