-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): Deprecate OpList::version and add versions instead #5481
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d67cead
Deprecate version and add versioned
geetanshjuneja 6be969c
deprecate oplist::version and change use of version to versioned
geetanshjuneja 08deaf4
refactor
geetanshjuneja eb451db
ruby test fix
geetanshjuneja b6a8ef0
test fix
geetanshjuneja cd886b5
more fn and fields deprecated
geetanshjuneja 76794d5
Use versions for better reading
Xuanwo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -486,9 +486,21 @@ impl<F: Future<Output = Result<Vec<Entry>>>> FutureList<F> { | |
/// by the underlying service | ||
/// | ||
/// Default to `false` | ||
#[deprecated = "use versioned instead"] | ||
pub fn version(self, v: bool) -> Self { | ||
self.map(|args| args.with_version(v)) | ||
} | ||
|
||
/// The version is used to control whether the object versions should be returned. | ||
/// | ||
/// - If `false`, list operation will not return with object versions | ||
/// - If `true`, list operation will return with object versions if object versioning is supported | ||
/// by the underlying service | ||
/// | ||
/// Default to `false` | ||
pub fn versioned(self, v: bool) -> Self { | ||
self.map(|args| args.with_version(v)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please also deprecate all use of |
||
} | ||
} | ||
|
||
/// Future that generated by [`Operator::list_with`] or [`Operator::lister_with`]. | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a version field:
0.51.1