Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Implement list with deleted and versions for oss #5527

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

hoslo
Copy link
Contributor

@hoslo hoslo commented Jan 9, 2025

Which issue does this PR close?

Part of #5496

Rationale for this change

Implement the oss in RFC we need.

What changes are included in this PR?

Implement list with deleted for oss services
Implement versions for oss services

Are there any user-facing changes?

Users can now list deleted files and user versions from oss services.

Copy link

codspeed-hq bot commented Jan 9, 2025

CodSpeed Performance Report

Merging #5527 will not alter performance

Comparing oss-list-with-deleted (f32074d) with main (5ae1a76)

Summary

✅ 73 untouched benchmarks

@Xuanwo Xuanwo requested a review from PsiACE as a code owner January 13, 2025 08:30
@Xuanwo
Copy link
Member

Xuanwo commented Jan 13, 2025

Hi, @hoslo, I have added a new test case for oss. Would you like to resolve the conflicts and test it again?

@hoslo hoslo force-pushed the oss-list-with-deleted branch from f5b9b81 to f32074d Compare January 13, 2025 11:17
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hoslo for this!

@Xuanwo Xuanwo merged commit f0b3aa3 into main Jan 13, 2025
95 checks passed
@Xuanwo Xuanwo deleted the oss-list-with-deleted branch January 13, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants