-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core)!: implement write returns metadata for s3 #5562
base: main
Are you sure you want to change the base?
Conversation
8591861
to
5c98d37
Compare
Well, well, well... Let's do our best to permit this since it's not harmful. Technically, we don't allow users to parse the ETag value; instead, they should store it and compare it with values from the same source. I'm guessing the issue lies in part of our code assuming that the ETag must contain |
No. The issue is that I compare the Etag from |
That's really surprising. Let's disable the Ceph RADOS test and create an issue to track it. I believe such a bug isn't worth our workaround. |
Which issue does this PR close?
Part of #5557
Rationale for this change
What changes are included in this PR?
write returns metadata
forOperator
andBlockingOperator
S3
Metadata
after writingAre there any user-facing changes?
Yes.
write
,write_with
inOperator
returnsResult<Metadata>
instead ofReturn<()>
Writer.close()
returnsReturn<Metadata>
instead ofReturn<()>
write
inBlockingOperator
returnsReturn<Metadata>
instead ofReturn<()>
FunctionWrite.call()
used byBlockingOperator
returnsReturn<Metadata>
instead ofReturn<()>