Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed config keys on Scala 2.13.x #5440

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

YevSent
Copy link
Contributor

@YevSent YevSent commented Sep 6, 2023

Desscription

The origin of issue is iteration through the config keys here and here and at the same time properties change in the loop which can lead to skipping some keys after +=.

  • Fixed an issue with missed config keys while iterating through them on Scala 2.13.x

!Note: This issue reproduces only on Scala >= 2.13.x version and probably related to some internal changes in Scala.

Related issue and scope

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

Merging #5440 (1558e79) into master (20f7d98) will decrease coverage by 0.29%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 1558e79 differs from pull request most recent head 10c1cae. Consider uploading reports for the commit 10c1cae to get more accurate results

@@            Coverage Diff             @@
##           master    #5440      +/-   ##
==========================================
- Coverage   76.82%   76.54%   -0.29%     
==========================================
  Files         241      241              
  Lines       14632    14634       +2     
  Branches      616      627      +11     
==========================================
- Hits        11241    11201      -40     
- Misses       3391     3433      +42     
Files Coverage Δ
...ain/scala/org/apache/openwhisk/common/Config.scala 85.29% <100.00%> (+0.91%) ⬆️

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@style95 style95 merged commit 597d61d into apache:master Nov 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants