Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Gang Wu <[email protected]>
  • Loading branch information
raunaqmorarka and wgtmac authored Oct 8, 2023
1 parent 868c6da commit 1595109
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions src/main/thrift/parquet.thrift
Original file line number Diff line number Diff line change
Expand Up @@ -216,21 +216,22 @@ struct Statistics {
/** count of distinct values occurring */
4: optional i64 distinct_count;
/**
* lower and upper bound values for the column, determined by its ColumnOrder.
* These may be the actual minimum and maximum values found on a column chunk,
* but can also be (more compact) values that do not exist on a column chunk.
* For example, instead of storing "Blart Versenwald III", a writer may set
* min_value="B", max_value="C". Such more compact values must still be valid
* values within the column's logical type.
* Lower and upper bound values for the column, determined by its ColumnOrder.
*
* These may be the actual minimum and maximum values found on a page or column
* chunk, but can also be (more compact) values that do not exist on a page or
* column chunk. For example, instead of storing "Blart Versenwald III", a writer
* may set min_value="B", max_value="C". Such more compact values must still be
* valid values within the column's logical type.
*
* Values are encoded using PLAIN encoding, except that variable-length byte
* arrays do not include a length prefix.
*/
5: optional binary max_value;
6: optional binary min_value;
/** If true, max_value is the actual maximum value found on a column chunk **/
/** If true, max_value is the actual maximum value for a column */
7: optional bool is_max_value_exact;
/** If true, min_value is the actual minimum value found on a column chunk **/
/** If true, min_value is the actual minimum value for a column */
8: optional bool is_min_value_exact;
}

Expand Down

0 comments on commit 1595109

Please sign in to comment.