Port imports and dependencies of CSV Samples to Pekko #6
Conversation
jackson 2.14.3 to match Pekko testcontainers 1.18.3 to address issue with Docker Desktop's authentication
| import akka.stream._ | ||
| import akka.stream.scaladsl.{ Sink, Source } | ||
| import akka.util.ByteString | ||
| import org.apache.pekko.Done |
There was a problem hiding this comment.
@reypader Pekko uses a root nested imports style, that is
import org.apache.pekko
import pekko.Done
import pekko.actor._
etc etcWould you be able to update the PR to this style for all .scala source files?
There was a problem hiding this comment.
I've been trying to play around with my formatters and scalafmt. I copied over scalafmt from pekko-connectors project even. No luck. I can't seem to find formatter config that would automatically do this for me. Could you show me how?
There was a problem hiding this comment.
It looks like you have a similar thread on this specific topic apache/pekko#414
Since this project is separate from incubator-pekko maybe it would be easier to enable scalafix here?
There was a problem hiding this comment.
Regarding scalafmt, this can be done later. For now I would just manually do the change I suggested
| @@ -31,8 +31,7 @@ | |||
|
|
|||
| <logger name="org.apache" level="WARN"/> | |||
| <logger name="kafka" level="WARN"/> | |||
| <logger name="akka" level="WARN"/> | |||
| <logger name="akka.kafka.benchmarks" level="INFO"/> | |||
| <logger name="org.apache.pekko" level="WARN"/> | |||
| <logger name="org.apache.kafka.common.utils.AppInfoParser" level="ERROR"/> | |||
There was a problem hiding this comment.
could you add back <logger name="org.apache.pekko.kafka.benchmarks" level="INFO"/> ?
|
done in other PRs |
Fixes #5