Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test with pekko 1.1 #212

Merged
merged 2 commits into from
Jul 12, 2024
Merged

test with pekko 1.1 #212

merged 2 commits into from
Jul 12, 2024

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Jul 12, 2024

  • changes main dependency to pekko 1.1 builds
  • repurposes the nightly pekko 1.1 job to use pekko 1.0 builds (because all the other builds will now use pekko 1.1 builds)
  • test with different scala versions

Got compile issues in Java 11, Scala 2.11 test compilation.
https://github.com/apache/pekko-persistence-cassandra/actions/runs/9907517623/job/27371382362

[info] compiling 67 Scala sources to /home/runner/work/pekko-persistence-cassandra/pekko-persistence-cassandra/core/target/scala-2.12/test-classes ...
[error] /home/runner/work/pekko-persistence-cassandra/pekko-persistence-cassandra/core/src/test/scala/org/apache/pekko/persistence/cassandra/query/EventsByTagSpec.scala:896:11: missing parameter type for expanded function
[error] The argument types of an anonymous function must be fully known. (SLS 8.5)
[error] Expected type was: ?
[error]           {
[error]           ^
[error] /home/runner/work/pekko-persistence-cassandra/pekko-persistence-cassandra/core/src/test/scala/org/apache/pekko/persistence/cassandra/query/EventsByTagSpec.scala:1131:48: missing parameter type for expanded function
[error] The argument types of an anonymous function must be fully known. (SLS 8.5)
[error] Expected type was: ?
[error]       probe.expectNextWithTimeoutPF(3.seconds, { case e @ EventEnvelope(_, "p1", 1L, "e1") => e })
[error]                                                ^
[error] /home/runner/work/pekko-persistence-cassandra/pekko-persistence-cassandra/core/src/test/scala/org/apache/pekko/persistence/cassandra/query/EventsByTagStageSpec.scala:293:45: missing parameter type for expanded function
[error] The argument types of an anonymous function must be fully known. (SLS 8.5)
[error] Expected type was: ?
[error]       sub.expectNextWithTimeoutPF(waitTime, { case EventEnvelope(_, "p-1", 10, "p1e10") => })
[error]                                             ^
[error] /home/runner/work/pekko-persistence-cassandra/pekko-persistence-cassandra/core/src/test/scala/org/apache/pekko/persistence/cassandra/query/EventsByTagStageSpec.scala:294:45: missing parameter type for expanded function
[error] The argument types of an anonymous function must be fully known. (SLS 8.5)
[error] Expected type was: ?
[error]       sub.expectNextWithTimeoutPF(waitTime, { case EventEnvelope(_, "p-1", 11, "p1e11") => })
[error]                                             ^
[error] /home/runner/work/pekko-persistence-cassandra/pekko-persistence-cassandra/core/src/test/scala/org/apache/pekko/persistence/cassandra/query/EventsByTagStageSpec.scala:545:[66](https://github.com/apache/pekko-persistence-cassandra/actions/runs/9907517623/job/27371382362#step:6:67): missing parameter type for expanded function
[error] The argument types of an anonymous function must be fully known. (SLS 8.5)
[error] Expected type was: ?
[error]       sub.expectNextWithTimeoutPF(newPersistenceIdTimeout * 1.1, { case EventEnvelope(_, "p-1", 11, "p1e11") => })
[error]

@pjfanning
Copy link
Contributor Author

Looks like apache/pekko#1218 may have had a negative impact on Scala 2.12 support for expectNextWithTimeoutPF. I raised apache/pekko#1393

I don't think there is a major issue if we just change the test code here to get it to work again.

@pjfanning pjfanning merged commit 332ba15 into apache:main Jul 12, 2024
12 checks passed
@pjfanning pjfanning deleted the connectors-1.1 branch July 12, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants