fix: migrator-integration-test tests not running #191

[Roiocam]

Motivation

Resolves: #191

Resolves in step by step

• investigation Migrator integration test compile issue.
• investigation package name is issue or not.
• investigation integration/testOnly will be an issue or not.

compile issue

migratorIntegration should be depend on migrator ✅

package name issue & sbt task issue

• sbt ++2.13 "clean; integration/testOnly org.apache.pekko.persistence.jdbc.integration.Postgres*"
• sbt ++2.13 "clean; testOnly org.apache.pekko.persistence.jdbc.integration.Postgres*": doesn't run anything
• sbt ++2.13 "clean; migratorIntegration/testOnly org.apache.pekko.persistence.jdbc.integration.Postgres*": doesn't run anything

both are unable to run PostgresJournalMigratorTest, both the package name and sbt tasks integration/testOnly have been verified to cause issues.

verify the solution

• sbt ++2.13 "integration/testOnly org.apache.pekko.persistence.jdbc.integration.Postgres*; migratorIntegration/testOnly org.apache.pekko.persistence.jdbc.migrator.integration.*" works, but looks like very long. ✅
• sbt ++2.13 "integration/testOnly; migratorIntegration/testOnly org.apache.pekko.persistence.jdbc.integration.Postgres*" can not filter other RDBMB.

[pjfanning]

As far as I can see, the main issue is that the yml files for the GitHub workflows run integation/testOnly ...

migratorIntegration is not included in the root project so I'm not even sure you can run the tests locally.

[Roiocam]

Seems like JournalMigratorTest is incorrect in SQLServer and Oracle:

in SQLServer:

JournalMigrator(SlickDatabase.profile(config, "slick")).migrate().futureValue shouldBe Done

will complain:

com.microsoft.sqlserver.jdbc.SQLServerException, with message: Cannot insert explicit value for identity column in table 'event_journal' when IDENTITY_INSERT is set to OFF...

[pjfanning]

@Roiocam I want to release v1.1.0-M1 of this module within the next week or 2. Would it be possible just to enable the tests for the dbs where this currently works and for us to come back to the broken ones after the v1.1.0-M1 release?

[Roiocam]

@pjfanning This PR is ready for review.

[pjfanning]

lgtm

[Roiocam]

@pjfanning Thanks for the review, I also fix SQLServer tests, can you take a look again?

[pjfanning]

@pjfanning Thanks for the review, I also fix SQLServer tests, can you take a look again?

thanks @Roiocam that sqlserver fix looks good.