Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move scala-reflect to top of dependencies #204

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

pjfanning
Copy link
Contributor

With #202, the pom has the scala-reflect dependency hidden at the bottom after all the test dependencies.

https://repository.apache.org/content/groups/staging/org/apache/pekko/pekko-persistence-jdbc_2.13/1.1.0-M1-RC2/pekko-persistence-jdbc_2.13-1.1.0-M1-RC2.pom

With this change, the dependency moves to 2nd - sbt adds scala-library dependency automatically and in first but by us listing scala-reflect first, it is listed in the pom 2nd after scala-library.

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@pjfanning pjfanning merged commit 0cf1d6d into apache:main Jun 3, 2024
23 checks passed
@pjfanning pjfanning deleted the pom-change branch June 3, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants