Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guava to 33.2.0-jre #1307

Merged
merged 1 commit into from
May 3, 2024
Merged

Update guava to 33.2.0-jre #1307

merged 1 commit into from
May 3, 2024

Conversation

scala-steward-asf[bot]
Copy link
Contributor

About this PR

📦 Updates com.google.guava:guava from 33.1.0-jre to 33.2.0-jre

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.google.guava", artifactId = "guava" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.google.guava", artifactId = "guava" }
}]
labels: test-library-update, early-semver-minor, semver-spec-minor, commit-count:1

@raboof
Copy link
Member

raboof commented May 3, 2024

link validator failure is unrelated:

## HTTP failure response
`[https://web.archive.org/web/20180114133958/http://roestenburg.agilesquad.com/2011/02/unit-testing-akka-actors-with-testkit_12.html`](https://web.archive.org/web/20180114133958/http://roestenburg.agilesquad.com/2011/02/unit-testing-akka-actors-with-testkit_12.html%60) status 429 Too Many Requests
 - testing.html

I wonder if we should remove the link validator from PR validation and instead run it nightly/weekly to monitor for longer-term failures?

@pjfanning
Copy link
Contributor

I strongly favour taking link validation off the main builds and have it run as a separate standalone run. It is just far too brittle.

@raboof
Copy link
Member

raboof commented May 3, 2024

I strongly favour taking link validation off the main builds and have it run as a separate standalone run. It is just far too brittle.

filed #1309

@raboof raboof merged commit 499ed3c into main May 3, 2024
18 checks passed
@pjfanning pjfanning deleted the update/guava-33.2.0-jre branch May 22, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants