Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-assembly to 2.3.0 #1528

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

scala-steward-asf[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates com.eed3si9n:sbt-assembly from 2.2.0 to 2.3.0

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

πŸ” Files still referring to the old version number

The following files still refer to the old version number (2.2.0).
You might want to review and update them manually.

docs/src/main/paradox/common/binary-compatibility-rules.md
βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.eed3si9n", artifactId = "sbt-assembly" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.eed3si9n", artifactId = "sbt-assembly" }
}]
labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, old-version-remains, commit-count:1

@Roiocam
Copy link
Member

Roiocam commented Oct 17, 2024

sbt/sbt-assembly#537

@@ -361,7 +361,7 @@ lazy val protobufV3 = pekkoModule("protobuf-v3")
.inProject),
assembly / assemblyOption := (assembly / assemblyOption).value.withIncludeScala(false).withIncludeBin(true),
autoScalaLibrary := false, // do not include scala dependency in pom
exportJars := true, // in dependent projects, use assembled and shaded jar
exportJars := false, // in dependent projects, use assembled and shaded jar
Copy link
Member

@Roiocam Roiocam Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, osgi packaging requireexportJars = true ? @pjfanning

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sbt-assembly 2.3.0 doesn't allow exportJars := true for this type of task- it fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants