-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support reading akka-persistence snapshots #837
Merged
pjfanning
merged 4 commits into
apache:1.0.x
from
pjfanning:reading-akka-persistence-snapshots
Dec 9, 2023
Merged
support reading akka-persistence snapshots #837
pjfanning
merged 4 commits into
apache:1.0.x
from
pjfanning:reading-akka-persistence-snapshots
Dec 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here, along with the code to generate it: package akka.persistence
import akka.actor.ActorSystem
import akka.serialization.{ SerializationExtension, SerializerWithStringManifest }
import akka.persistence.serialization.Snapshot
import akka.persistence.fsm.PersistentFSM.PersistentFSMSnapshot
import java.util.Base64
object MakeTestSnapshot extends App {
val system = ActorSystem()
val serialization = SerializationExtension(system)
val bytes = serialization.serialize(Snapshot(PersistentFSMSnapshot[String]("test-identifier", "test-data", None)))
val base64 = Base64.getEncoder.encode(bytes.get)
println(new String(base64)) // PAAAAAcAAABha2thLnBlcnNpc3RlbmNlLmZzbS5QZXJzaXN0ZW50RlNNJFBlcnNpc3RlbnRGU01TbmFwc2hvdAoPdGVzdC1pZGVudGlmaWVyEg0IFBIJdGVzdC1kYXRh
} and test deserialization on pekko: import org.apache.pekko.actor.ActorSystem
import org.apache.pekko.serialization.{ SerializationExtension, SerializerWithStringManifest }
import java.util.Base64
import org.apache.pekko.persistence.serialization.Snapshot
val system = ActorSystem()
val serialization = SerializationExtension(system)
val bytes = Base64.getDecoder.decode("PAAAAAcAAABha2thLnBlcnNpc3RlbmNlLmZzbS5QZXJzaXN0ZW50RlNNJFBlcnNpc3RlbnRGU01TbmFwc2hvdAoPdGVzdC1pZGVudGlmaWVyEg0IFBIJdGVzdC1kYXRh")
val result = serialization.deserialize(bytes, classOf[Snapshot]) |
pjfanning
changed the title
[DRAFT] support reading akka-persistence snapshots
support reading akka-persistence snapshots
Dec 9, 2023
pjfanning
requested review from
He-Pin,
nvollmar,
mdedetrich and
samueleresca
December 9, 2023 10:36
nvollmar
approved these changes
Dec 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
pjfanning
added a commit
to pjfanning/incubator-pekko
that referenced
this pull request
Dec 9, 2023
* support reading akka-persistence snapshots * add test * Update SnapshotSerializerSpec.scala * Update SnapshotSerializerSpec.scala
pjfanning
added a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SakulK would you be able to share a persisted akka snapshot? In base64 format, maybe. It would be useful to have some sort of test.