Use recoverWith instead of recover in SnapshotSerializer akka backwards compatibility
#841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SakulK have you tried out this change in an end to end use case? I would like to avoid making a large number of PRs here. I'm happy to change this but I would prefer to get it right this time around. |
|
@pjfanning yes, this works for me end-to-end |
pjfanning
pushed a commit
to pjfanning/incubator-pekko
that referenced
this pull request
Dec 11, 2023
…ds compatibility (apache#841)
This was referenced Dec 11, 2023
pjfanning
added a commit
that referenced
this pull request
Dec 12, 2023
…ds compatibility (#841) (#843) Co-authored-by: Łukasz Krenski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pjfanning after taking another look I think this should make more sense, otherwise
snapshotFromBinarycan either returnTorTry[T](got bitten byAnyRefhere..). I'm not sure why the previous version didn't blow up when testing this with real mongo and existing akka persistence snapshots.