fix: Fixed how Modbus tags produce their array-info

apache · Oct 2, 2024 · 4de3701 · 4de3701
1 parent 24c9392
commit 4de3701
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/plc4j/drivers/modbus/src/main/java/org/apache/plc4x/java/modbus/base/tag/ModbusTag.java b/plc4j/drivers/modbus/src/main/java/org/apache/plc4x/java/modbus/base/tag/ModbusTag.java
@@ -75,7 +75,7 @@ public String getAddressString() {
             address += ":" + getDataType().name();
         }
         if(!getArrayInfo().isEmpty()) {
-            address += "[" + getArrayInfo().get(0).getUpperBound() + "]";
+            address += "[" + (getArrayInfo().get(0).getUpperBound() + 1) + "]";
         }
         return address;
     }
@@ -158,7 +158,7 @@ public PlcValueType getPlcValueType() {
     @Override
     public List<ArrayInfo> getArrayInfo() {
         if(quantity != 1) {
-            return Collections.singletonList(new DefaultArrayInfo(0, quantity));
+            return Collections.singletonList(new DefaultArrayInfo(0, quantity - 1));
         }
         return Collections.emptyList();
     }

diff --git a/plc4j/drivers/modbus/src/test/java/org/apache/plc4x/java/modbus/ModbusTagTest.java b/plc4j/drivers/modbus/src/test/java/org/apache/plc4x/java/modbus/ModbusTagTest.java
@@ -39,7 +39,7 @@ private void verifyModbusTag(List<String> tagPatterns,
                                  int allowedMax,
                                  Class<? extends ModbusTag> expectedClass,
                                  int expectedAddressShift) {
-        // Ensure all tagpatterns compile to the right tag
+        // Ensure all tag patterns compile to the right tag
         for (int i = 1; i <= allowedMax; i++) {
             List<ModbusTag> tags = new ArrayList<>();
             for (String tagPattern : tagPatterns) {