Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert images into document with shapes #458

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from
Open

Insert images into document with shapes #458

wants to merge 7 commits into from

Commits on Apr 19, 2023

  1. Add test to recreate problem 

    - given a document with 0 - 10 shapes
- inserting 0 to 10 images
- works for inserting 0 to 1 images
- fails for more than 1 image
- no matter the amount of shapes
    Georg Berky committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    4dd6f72 View commit details
    Browse the repository at this point in the history

  2. Test with multiple images

    Georg Berky committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    09e5ce7 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Read docPr IDs and check if there are duplicates 

    Co-authored-by: Christina Eckleder <[email protected]>
    Georg Berky and Christina Eckleder committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    7b60758 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Put shapes in footer 

    - also use footer paragraphs in workaround
- still produces broken documents :(

Co-authored-by: Christina Eckleder <[email protected]>
    Georg Berky and Christina Eckleder committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    4e528ae View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Run workaround after loading 

    - doesn't fix "cannot load document" error
    Georg Berky committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    4b0aa16 View commit details
    Browse the repository at this point in the history

  2. Try to find all wp:docPr in all paragraphs 

    - still not improving
    Georg Berky committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    7fabab2 View commit details
    Browse the repository at this point in the history

  3. Disable writing to file again

    Georg Berky committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    619d32d View commit details
    Browse the repository at this point in the history