Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated TLS to v1.2 for TimeStampSimpleHttpClient #581

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

wreicherz
Copy link

simple update of chosen algo. ("TLS"); vs. ("TLSv1.2");

@pjfanning
Copy link
Contributor

Are you making this change just because it looks wrong or because you have hit an issue?

With POI, we work with real use cases because the Microsoft specs can be hard to interpret.

@pjfanning
Copy link
Contributor

the logic you are changing only appears to happens when ignoreHttpsCertificates = true - are you changing to this true (it defaults to false)

Ideally you should not ignore the HTTPS certs

@wreicherz
Copy link
Author

wreicherz commented Feb 1, 2024

Are you making this change just because it looks wrong or because you have hit an issue?

To prevent incompatibility in the future, due to the deprecated state of the algo

No current issues whatsoever, (very) low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants