[WIP] Quarkus: separate service module from server artifact #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2025
adutra
force-pushed
the
quarkus-split-service
branch
5 times, most recently
from
652309e to
5fa469d
Compare
adutra
force-pushed
the
quarkus-split-service
branch
from
5fa469d to
b8d029d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #469 and #604.
This PR splits
polaris-quarkus-servicein two modules:polaris-quarkus-servicecontains all the Quarkus-specific components needed for the server, and soon, for the admin tool as well.polaris-quarkus-serverbuilds the final artifact (the runnable server). It contains the server'sapplication.propertiesand theDockerfile.jvmto build the docker image.This PR is mainly motivated by reusability of
application.propertiesfiles in the classpath. The common parts of the configuration are inpolaris-quarkus-service; configuration specific to either the server or the future admin tool, will be kept in their respective modules.This PR also fixes the server binary distribution by adapting it to Quarkus.