Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Adapt documentation, examples and demo scripts to Quarkus runtime #700

Closed
wants to merge 3 commits into from
Closed

[WIP] Adapt documentation, examples and demo scripts to Quarkus runtime #700

wants to merge 3 commits into from

Conversation

adutra
Copy link
Contributor

@adutra adutra commented Jan 10, 2025

⚠️ Not ready for review yet!

This is the last PR in the Quarkus switch series.

@adutra adutra force-pushed the quarkus-documentation branch 8 times, most recently from 91f0236 to 4c66c63 Compare January 12, 2025 20:54
This was referenced Jan 14, 2025
Merged
Merged
Merged
@adutra adutra force-pushed the quarkus-documentation branch from 4c66c63 to 98056e0 Compare January 14, 2025 15:56
@adutra adutra force-pushed the quarkus-documentation branch 2 times, most recently from 501cfd6 to 875f046 Compare January 14, 2025 17:04
flyrain
flyrain reviewed Jan 14, 2025
View reviewed changes
README.md Outdated

For local development, you can run the following commands:

- `./gradlew --console=plain :polaris-quarkus-service:quarkusRun` - To run the Polaris server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script failed locally, missing a dependent?

2025-01-14 09:28:33,370 ERROR [io.qua.run.Application] [,] [,,,] (main) Failed to start application: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
	at io.quarkus.runtime.Application.start(Application.java:101)
	at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:121)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:71)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:44)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:124)
	at io.quarkus.runner.GeneratedMain.main(Unknown Source)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.bootstrap.runner.QuarkusEntryPoint.doRun(QuarkusEntryPoint.java:62)
	at io.quarkus.bootstrap.runner.QuarkusEntryPoint.main(QuarkusEntryPoint.java:33)
Caused by: java.lang.NoClassDefFoundError: io/opentelemetry/sdk/metrics/internal/export/CardinalityLimitSelector
	at io.opentelemetry.sdk.autoconfigure.MeterProviderConfiguration.lambda$configureMeterProvider$1(MeterProviderConfiguration.java:65)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at io.opentelemetry.sdk.autoconfigure.MeterProviderConfiguration.configureMeterProvider(MeterProviderConfiguration.java:63)
	at io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdkBuilder.build(AutoConfiguredOpenTelemetrySdkBuilder.java:452)
	at io.quarkus.opentelemetry.runtime.OpenTelemetryRecorder$1.apply(OpenTelemetryRecorder.java:81)
	at io.quarkus.opentelemetry.runtime.OpenTelemetryRecorder$1.apply(OpenTelemetryRecorder.java:54)
	at io.opentelemetry.api.OpenTelemetry_Le6zQbzkojAYO_OiKIQWJf4lGa4_Synthetic_Bean.createSynthetic(Unknown Source)
	at io.opentelemetry.api.OpenTelemetry_Le6zQbzkojAYO_OiKIQWJf4lGa4_Synthetic_Bean.doCreate(Unknown Source)
	at io.opentelemetry.api.OpenTelemetry_Le6zQbzkojAYO_OiKIQWJf4lGa4_Synthetic_Bean.create(Unknown Source)
	at io.opentelemetry.api.OpenTelemetry_Le6zQbzkojAYO_OiKIQWJf4lGa4_Synthetic_Bean.create(Unknown Source)
	at io.quarkus.arc.impl.AbstractSharedContext.createInstanceHandle(AbstractSharedContext.java:119)
	at io.quarkus.arc.impl.AbstractSharedContext$1.get(AbstractSharedContext.java:38)
	at io.quarkus.arc.impl.AbstractSharedContext$1.get(AbstractSharedContext.java:35)
	at io.quarkus.arc.impl.LazyValue.get(LazyValue.java:32)
	at io.quarkus.arc.impl.ComputingCache.computeIfAbsent(ComputingCache.java:69)
	at io.quarkus.arc.impl.ComputingCacheContextInstances.computeIfAbsent(ComputingCacheContextInstances.java:19)
	at io.quarkus.arc.impl.AbstractSharedContext.get(AbstractSharedContext.java:35)
	at io.opentelemetry.api.OpenTelemetry_Le6zQbzkojAYO_OiKIQWJf4lGa4_Synthetic_Bean.get(Unknown Source)
	at io.opentelemetry.api.OpenTelemetry_Le6zQbzkojAYO_OiKIQWJf4lGa4_Synthetic_Bean.get(Unknown Source)
	at io.quarkus.arc.impl.InstanceImpl.getBeanInstance(InstanceImpl.java:325)
	at io.quarkus.arc.impl.InstanceImpl.getInternal(InstanceImpl.java:309)
	at io.quarkus.arc.impl.InstanceImpl.get(InstanceImpl.java:190)
	at io.quarkus.arc.runtime.BeanContainerImpl.beanInstance(BeanContainerImpl.java:26)
	at io.quarkus.opentelemetry.runtime.tracing.intrumentation.InstrumentationRecorder.setupVertxTracer(InstrumentationRecorder.java:59)
	at io.quarkus.deployment.steps.OpenTelemetryProcessor$setupVertx1012958309.deploy_0(Unknown Source)
	at io.quarkus.deployment.steps.OpenTelemetryProcessor$setupVertx1012958309.deploy(Unknown Source)
	... 11 more
Caused by: java.lang.ClassNotFoundException: io.opentelemetry.sdk.metrics.internal.export.CardinalityLimitSelector
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
	at io.quarkus.bootstrap.runner.RunnerClassLoader.loadClass(RunnerClassLoader.java:114)
	at io.quarkus.bootstrap.runner.RunnerClassLoader.loadClass(RunnerClassLoader.java:72)
	... 37 more

Copy link
Contributor Author

@adutra adutra Jan 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops there is an enforcedPlatform missing somewhere, let me dig it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed now with a workaround, and I opened #750 to track progress on this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adutra. What was the workaround?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workaround is to run :polaris-quarkus-server:quarkusRun instead of :polaris-quarkus-service:quarkusRun. It boils down to the same from a user perspective (it runs the same app), and the advantage is that in polaris-quarkus-server, Quarkus is imported with enforcedPlatform so the error does not happen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quarkusRun does not rely on Docker. It runs the application from the build directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for quarkusDev.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for sharing. Do we have to wait for #610 in that case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we should fix all the things first (basically at this point: Docker, Helm and a bit of the regression tests), and then fix the documentation – otherwise, you might write some documentation that won't reflect what the code would eventually end up looking like.

If you are in a hurry, I can look into splitting the docs into many pieces. But that will have to wait until Monday :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine either way with a bit worries about that #610 might take a long time. Have a nice weekend! Let's resume on Monday!

@adutra adutra force-pushed the quarkus-documentation branch from 875f046 to 0ef1b36 Compare January 14, 2025 18:53
@adutra adutra force-pushed the quarkus-documentation branch from 0ef1b36 to 8172ca2 Compare January 15, 2025 09:52
@eric-maynard eric-maynard mentioned this pull request Jan 17, 2025
Closed
@adutra
Copy link
Contributor Author

adutra commented Jan 20, 2025

Closing as I was requested to split this PR in smaller pieces.

@adutra adutra closed this Jan 20, 2025
@adutra adutra mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-maynard eric-maynard eric-maynard left review comments

@flyrain flyrain flyrain left review comments

@ashvina ashvina Awaiting requested review from ashvina ashvina will be requested when the pull request is marked ready for review ashvina is a code owner

@dennishuo dennishuo Awaiting requested review from dennishuo dennishuo will be requested when the pull request is marked ready for review dennishuo is a code owner

@dimas-b dimas-b Awaiting requested review from dimas-b dimas-b will be requested when the pull request is marked ready for review dimas-b is a code owner

@jackye1995 jackye1995 Awaiting requested review from jackye1995 jackye1995 will be requested when the pull request is marked ready for review jackye1995 is a code owner

@jbonofre jbonofre Awaiting requested review from jbonofre jbonofre will be requested when the pull request is marked ready for review jbonofre is a code owner

@vvcephei vvcephei Awaiting requested review from vvcephei vvcephei will be requested when the pull request is marked ready for review vvcephei is a code owner

@collado-mike collado-mike Awaiting requested review from collado-mike collado-mike will be requested when the pull request is marked ready for review collado-mike is a code owner

@snazy snazy Awaiting requested review from snazy snazy will be requested when the pull request is marked ready for review snazy is a code owner

@RussellSpitzer RussellSpitzer Awaiting requested review from RussellSpitzer RussellSpitzer will be requested when the pull request is marked ready for review RussellSpitzer is a code owner

@takidau takidau Awaiting requested review from takidau takidau will be requested when the pull request is marked ready for review takidau is a code owner

@ebyhr ebyhr Awaiting requested review from ebyhr ebyhr will be requested when the pull request is marked ready for review ebyhr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adutra @flyrain @eric-maynard