Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BasePolarisAuthenticator to throw service exception during persistence errors #707

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

collado-mike
Copy link
Contributor

In cases when the persistence store in unavailable or experiencing errors, the authenticator catches exceptions and causes the service to incorrectly return 401. These exceptions are almost never retried by upstream clients or reverse proxies, so intermittent failures will cause clients to simply shut down. This correctly throws ServiceFailureExceptions in these cases and adds a unit test specifically for the BasePolarisAuthenticator

@collado-mike collado-mike merged commit f524088 into apache:main Jan 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants