Optimize shouldUpdateAddressList method using containsAll

apache · Dec 10, 2024 · 2152ae8 · 2152ae8
1 parent 4f0c8ff
commit 2152ae8
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java
@@ -526,13 +526,7 @@ private static boolean shouldUpdateAddressList(List<String> newAddresses, List<S
             return true;
         }
 
-        for (String addr : newAddresses) {
-            if (!oldAddresses.contains(addr)) {
-                return true;
-            }
-        }
-
-        return false;
+        return !new HashSet<>(newAddresses).containsAll(oldAddresses);
     }
 
     /**