[ISSUE #8777] enhance error log when when can't connect to namesrv addrs #8778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8778 +/- ##
==========================================
Coverage 47.37% 47.38%
+ Complexity 11558 11557 -1
==========================================
Files 1282 1282
Lines 89864 89864
Branches 11563 11563
==========================================
+ Hits 42575 42579 +4
+ Misses 42040 42032 -8
- Partials 5249 5253 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RongtongJin
approved these changes
Oct 3, 2024
3424672656
approved these changes
Oct 15, 2024
lizhanhui
reviewed
Oct 23, 2024
| @@ -839,8 +839,8 @@ public boolean updateTopicRouteInfoFromNameServer(final String topic, boolean is | |||
| log.warn("updateTopicRouteInfoFromNameServer Exception", e); | |||
| } | |||
| } catch (RemotingException e) { | |||
| log.error("updateTopicRouteInfoFromNameServer Exception", e); | |||
| throw new IllegalStateException(e); | |||
| log.error("updateTopicRouteInfoFromNameServer Exception, namesrvAddr: " + clientConfig.getNamesrvAddr(), e); | |||
There was a problem hiding this comment.
Please log with formatter, not string concatenation. See https://medium.com/@mohanakrishnakavali/logging-efficiency-in-java-string-concatenation-vs-string-format-efa02055ddae
There was a problem hiding this comment.
This errorMessage string is always being constructed. How about if I change it to the following code?
String errorMessage = String.format("updateTopicRouteInfoFromNameServer Exception, namesrvAddr: %s", clientConfig.getNamesrvAddr());
log.error(errorMessage, e);
throw new IllegalStateException(errorMessage, e);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8777
Brief Description
How Did You Test This Change?