Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #8854]refactor(proxy): refactor proxy server with spi #8855

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

[ISSUE #8854]refactor(proxy): refactor proxy server with spi #8855

wants to merge 4 commits into from

Conversation

xiaoma20082008
Copy link

Which Issue(s) This PR Fixes

Fixes #8854

Brief Description

Use spi to refactor the grpc/remoting implemention and http in the future

How Did You Test This Change?

@xiaoma20082008 xiaoma20082008 marked this pull request as ready for review October 23, 2024 01:59
@xiaoma20082008 xiaoma20082008 changed the title refactor(proxy): refactor proxy server with spi [ISSUE #8854]refactor(proxy): refactor proxy server with spi Oct 23, 2024
fuyou001
fuyou001 previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoma20082008
Copy link
Author

@fuyou001 I have formatted the code, please review again, thank you

@xiaoma20082008
Copy link
Author

This code of ProxyMetricsManager should also be refactored, but I don't quite understand its implementation logic, if you want,please give me some tips.

@qianye1001
Copy link
Contributor

How to ensure the start and shutdown order of MixedProxyServer

@xiaoma20082008
Copy link
Author

xiaoma20082008 commented Dec 11, 2024 •
edited
Loading

How to ensure the start and shutdown order of MixedProxyServer

  1. The MixedProxyServer 's usage is only to start other servers.
  2. Then each implementation is independent so it's orderless, and now it's based on the file order in proxy/src/main/resources/META-INF/services/org.apache.rocketmq.proxy.spi.ProxyServerFactory.
  3. If you need order, we can choose one of the following list:
  • add a new method int getOrder() to org.apache.rocketmq.proxy.spi.ProxyServer OR
  • create a new configuration in ProxyConfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuyou001 fuyou001 fuyou001 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] refactor the proxy server with spi implementions
3 participants
@xiaoma20082008 @qianye1001 @fuyou001