Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9069] Fix the IndexFile ConcurrentModificationException in tiered storage #9071

Conversation

wangshaojie4039
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #9069

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 83.09859% with 12 lines in your changes missing coverage. Please review.

Project coverage is 47.98%. Comparing base (16b6e53) to head (b675339).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...q/tieredstore/core/MessageStoreDispatcherImpl.java 73.33% 5 Missing and 7 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9071      +/-   ##
=============================================
+ Coverage      47.84%   47.98%   +0.13%     
- Complexity     11865    12044     +179     
=============================================
  Files           1312     1320       +8     
  Lines          91740    92791    +1051     
  Branches       11752    11901     +149     
=============================================
+ Hits           43890    44522     +632     
- Misses         42427    42762     +335     
- Partials        5423     5507      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lizhimins lizhimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add some test cases for context

@lizhimins lizhimins changed the title fix tiered store ConstructIndexFile ConcurrentModificationException [ISSUE #9069] Fix tiered store IndexFile construct ConcurrentModificationException Dec 20, 2024
@lizhimins lizhimins changed the title [ISSUE #9069] Fix tiered store IndexFile construct ConcurrentModificationException [ISSUE #9069] Fix the IndexFile ConcurrentModificationException in tiered storage Dec 20, 2024
@lizhimins lizhimins merged commit 152a955 into apache:develop Dec 25, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] tiered store ConstructIndexFile ConcurrentModificationException
3 participants