Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9075]Avoid message type validate in message sync scenario. #9076

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

dingshuangxi888
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #9075

Brief Description

Avoid message type validate in message sync scenario.

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 47.99%. Comparing base (35a6426) to head (186f38f).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
...va/org/apache/rocketmq/common/message/Message.java 0.00% 3 Missing ⚠️
...he/rocketmq/proxy/processor/ProducerProcessor.java 0.00% 0 Missing and 3 partials ⚠️
...q/proxy/remoting/activity/SendMessageActivity.java 0.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9076      +/-   ##
=============================================
+ Coverage      47.98%   47.99%   +0.01%     
+ Complexity     12027    12019       -8     
=============================================
  Files           1319     1319              
  Lines          92743    92720      -23     
  Branches       11895    11888       -7     
=============================================
- Hits           44499    44498       -1     
+ Misses         42744    42717      -27     
- Partials        5500     5505       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 1c35adb into apache:develop Dec 25, 2024
10 of 11 checks passed
@dingshuangxi888 dingshuangxi888 deleted the skip_check_message_type branch December 25, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Avoid message type validate in message sync scenario.
3 participants