Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8895] Fix NPE when broker shutdown and optimize the log #9094

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

qianye1001
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8895

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.92%. Comparing base (b30afe8) to head (36bf4d6).

Files with missing lines Patch % Lines
...rocketmq/common/config/AbstractRocksDBStorage.java 0.00% 1 Missing ⚠️
...org/apache/rocketmq/store/DefaultMessageStore.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9094      +/-   ##
=============================================
- Coverage      47.93%   47.92%   -0.01%     
  Complexity     12049    12049              
=============================================
  Files           1321     1321              
  Lines          93021    93022       +1     
  Branches       11925    11925              
=============================================
- Hits           44586    44579       -7     
- Misses         42925    42930       +5     
- Partials        5510     5513       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qianye1001 qianye1001 changed the title [ISSUE #8895] CreateFlushConsumeQueueService for loadAndStartConsumerServiceOnly [ISSUE #8895] Fix NPE when broker shutdown and optimize the log Jan 14, 2025
Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 94d9185 into apache:develop Jan 14, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] CreateFlushConsumeQueueService for loadAndStartConsumerServiceOnly
5 participants