-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add : Support outputting the result of 'verify' in YAML format and only outputting the summary of the result of 'verify' #115
Conversation
What does |
In my opinion, the |
@chunriyeqiongsaigao |
I am a little confused. From what I read from your demo, the |
We need this PR to make e2e (the dev version) output the verify result in yaml format, so that another e2e (the stable version) can use the yaml output to verify if the dev version e2e works well, just like we discussed in this |
OK. This seems more like @kezhenxu94 Are you aware of the naming thing? Any suggestion? |
Yes |
OK, I will edit the code later. Thanks! |
If we consider more formats, we should consider this in two parts.
|
I'm not quite aware of the naming thing. @chunriyeqiongsaigao Can you ping your mentor here. From my understanding, if this is about the output format, then the format name might not be a good command option |
|
|
Make sense, I will discuss with the student. |
Please update PR title and descriptions to fit your latest codes. |
Sure, I will update the PR title and descriptions to align with the latest changes in the code. Thank you for the reminder. |
I think new command style is good. I want to confirm, is the real tests for this tool will come next? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically correct 👍, but need some polish
Yes, the student has made a POC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, well done!
@fgksgf After further tests are added, are we planning a new release? It has been 24 commits included and over a year since the last release. v1.2.0...main |
@wu-sheng No problem, i will do this. |
Added a new command-line parameter
-o
, which stands for--output
. The value of this parameter represents the format in which the summary of theverify
results should be outputted. Currently, only YAML format is supported, the value of which isyaml
. If the commande2e verify -c e2e.yaml -o yaml
is entered, only the summary in YAML format will be outputted to the CL.Added a new command-line parameter
--summary-only
. If the commande2e verify -c e2e.yaml --summary-only
is entered, only theSUMMARY
part ofverify
results will be outputted to the CL.example:
This is the
cases
section of thee2e.yaml
config file forverify
. It provides 4 cases for e2e toveriy
. And case-1, case-2, and case-4 will pass, while case-3 will fail.-o yaml
:./bin/linux/e2e verify -c ../e2e/e2e.yaml
-o yaml
:./bin/linux/e2e verify -c ../e2e/e2e.yaml -o yaml
--summary-only
:./bin/linux/e2e verify -c ../e2e/e2e.yaml
--summary-only
:./bin/linux/e2e verify -c ../e2e/e2e.yaml --summary-only