Make e2e test itself in github action #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
reviewed
Sep 3, 2023
.github/workflows/e2e-test.yaml
Outdated
| jobs: | ||
| build: | ||
|
|
||
| name: Build |
There was a problem hiding this comment.
Should this rename to e2e? Build seems strange.
There was a problem hiding this comment.
OK, Thanks very much !
kezhenxu94
reviewed
Sep 4, 2023
fgksgf
reviewed
Sep 4, 2023
fgksgf
changed the title
fgksgf
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
LGTM, look forward to adding other test cases 👍 @chunriyeqiongsaigao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several directories and files, and their relationships are depicted as follows:
This PR solely introduces directories and files (e2e configuration file & github-action configuration file) without altering the existing functionality of e2e. The purpose of this PR is to implement Use Infra E2E to test itself.
This PR currently implements the
fail-fastandnon-fail-fasttesting modes in thenon-concurrencymode only. The plan is to implement thefail-fastandnon-fail-fasttesting modes in theconcurrencymode in the subsequent PRs.