Get correct SolrPods in SolrCloud controller #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SolrCloud controller needs to fetch the list of Solr Pods for a given SolrCloud, in order to determine what to restart and construct the SolrCloud.Status object. However, when an old SolrCloud has been deleted and a new SolrCloud has been created (with the same name), there may be time when the new SolrCloud has been created, but the Pods for the old SolrCloud have not yet been deleted. So the SolrCloud controller will then think that the old Pods are related to the new SolrCloud, because they have the right labels. This isn't the case however, so we need to make sure that only the SolrCloud Pods that are actually related to that SolrCloud are fetched.
This is unlikely to show up in a production setting, but it causes havoc with the integration tests more than occasionally.
I have also added the StatefulSet json to the output for integration tests, allowing us to better debug failures.