Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(solr-zk) Switch from zkcli to solr zk command line #738

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mcarroll1
Copy link

This is primarily intended as a fix for #731 and #720.

This PR switches the setup-zk initcontainer from using the zkcli to solr zk .... The zkcli is deprecated and will be removed in Solr 10. Also, this PR fixes bootstrapping with a custom security.json that was broken in v9.7.

Please see comments in implementation.

I've updated the unit tests, and added an integration test for bootstrapping with a custom security.json. Below is the output of running that test:

make e2e-tests TEST_FILTER="E2E - SolrCloud - Security JSON"
...



Will run 1 of 28 specs
Running in parallel across 3 processes
SSSSSSSSSSSSSSSSSSSSSSSSSSS•

Ran 1 of 28 Specs in 82.823 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 27 Skipped


Ginkgo ran 1 suite in 1m33.993254375s
Test Suite Passed

********************

Copy link

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting to see an example of a change plus the test to go with it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants