SOLR-17483: Backport cleanup zk-related logic in bin/solr.cmd #2823
Conversation
* Remove ZK logic from solr.cmd as it is obsolete * Fix unreachable auth tool in solr.cmd * Fix invalid references (cherry picked from commit c2091d0)
The closing parentheses caused the IF to be closed before the echo message was fully printed, leading to "mode." being executed instead of printed.
malliaridis
changed the title
|
I know we want to add windwos testing, but I wouldn't let that hold this up. |
|
Since there are bugfixes included as well, I think we are good to go. There is no ETA for the Windows testing, so it should not be a blocker. |
|
I just saw a bug report (with a patch!) reported to the dev list: https://issues.apache.org/jira/browse/SOLR-17551. Looking a bit closer, I wonder if we apply this PR to branch_9x and branch_9_7, then does this fix the reported bug as well, or if we only do the bug fix in branch_9_7, and leave this one to go to branch_9x? |
|
It seems to be backwards compatible, so there is probably no issues backport this to branch_9_7 as well. :) |
|
I've further looked into backporting this, but it would break compatibility to other deprecated commands, which we probably don't want to mess with again. I would therefore apply the patch from https://issues.apache.org/jira/browse/SOLR-17551 instead. |
Awesome. Could I talk you into applying it? I don't have a windows box and it's tricky enough I don't want to break things worse. Thanks for making a decision on which way to go!!!! |
|
Leaving this as a note: Mistakenly changed the commit message with vim during cherrypick. The correct issue is SOLR-17483, not SOLR-17484. |
https://issues.apache.org/jira/browse/SOLR-17483
Description
See #2816 for details.
Additionally, this PR also fixes a bug introduced in 7892085 that lead to "mode." form an echo message being executed as a command.
Solution
See #2816 for details.
Tests
Windows tests still pending. See SOLR-17508.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.