SOLR-17535: Deprecate ClusterState.forEachCollection #2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use collectionStream() instead. Redirect callers. A simple refactoring.
murblanc
reviewed
Nov 8, 2024
| @@ -425,7 +425,10 @@ public Stream<DocCollection> collectionStream() { | |||
| /** | |||
| * Calls {@code consumer} with a resolved {@link DocCollection}s for all collections. Use this | |||
| * sparingly in case there are many collections. | |||
| * | |||
| * @deprecated see {@link #collectionStream()} | |||
There was a problem hiding this comment.
If this method was introduced a few days ago (can't remember), I think it can be removed rather than deprecated.
There was a problem hiding this comment.
It has existed for some releases, thus I deprecate it.
murblanc
approved these changes
Nov 8, 2024
|
I'll merge this Monday in case there are any further comments, but I wouldn't anticipate any for this simple one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use collectionStream() instead. Redirect callers. A simple refactoring.
https://issues.apache.org/jira/browse/SOLR-17535