[SPARK-50650][SQL] Improve logging in single-pass Analyzer #49271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Dec 23, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/PlanLogger.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Dec 23, 2024
...lyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/ExpressionResolver.scala
Show resolved
Hide resolved
vladimirg-db
force-pushed
the
vladimirg-db/single-pass-analyzer/improve-plan-logger
branch
from
0dd8452 to
8a0bdbb
Compare
|
LGTM. I think there are no major issues, Wenchen. Could we merge it, please? |
vladimirg-db
force-pushed
the
vladimirg-db/single-pass-analyzer/improve-plan-logger
branch
from
8a0bdbb to
a70fb64
Compare
cloud-fan
approved these changes
Dec 25, 2024
|
LGTM, can you give some logging examples for some simple queries? |
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
To make single-pass Analyzer debugging easier.
Examples:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.