Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2729) improve split array processor support nested field #2948

Closed
wants to merge 1 commit into from

Conversation

yanfeng1992
Copy link
Contributor

Purpose

#2729
improve split array processor support nested field

Remarks

PR introduces (a) breaking change(s): <yes/no>

PR introduces (a) deprecation(s): <yes/no>

@github-actions github-actions bot added java Pull requests that update Java code pipeline elements Relates to pipeline elements backend Everything that is related to the StreamPipes backend labels Jun 19, 2024
@yanfeng1992 yanfeng1992 marked this pull request as draft June 19, 2024 11:49
@yanfeng1992 yanfeng1992 marked this pull request as ready for review June 19, 2024 12:17
Copy link
Member

@dominikriemer dominikriemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yanfeng1992 thanks for the PR!
Since the changes also affect the description, we should also add a migration to make sure existing pipelines using the old model are properly updated.
You can take a look at the MsTeamsSinkMigration as an example and I'm happy to help if you have any questions.

Copy link
Contributor

Hello there 👋

We noticed that it's been some time since activity occurred on your pull request 🤔. In order to keep things moving forward, we're marking this PR as stale and giving you 7 days to respond before it's automatically closed ⏰.

Please take a moment to review your pull request and make any necessary updates or changes 👨‍💻. If you need more time or have any questions, please don't hesitate to let us know 💬.

Thank you for your contributions to our project, and we look forward to hearing back from you soon 🙏.

@github-actions github-actions bot added the stale Marks pull requests that are classified as `stale` by our bot. label Jul 17, 2024
Copy link
Contributor

Hello there 👋

Unfortunately, we didn't hear back from you regarding your pull request, so we're closing it now. Don't worry, you can always reopen the PR at any time if you wish to continue working on it 🙌.

Please note that the branch associated with this pull request will not be deleted, so you can still access your changes and continue to work on them as needed 💻.

Thank you for your contributions to our project, and we hope to see you again soon!

@github-actions github-actions bot closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Everything that is related to the StreamPipes backend java Pull requests that update Java code pipeline elements Relates to pipeline elements stale Marks pull requests that are classified as `stale` by our bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants