fix path error

apache · Nov 19, 2023 · 1076fa4 · 1076fa4
1 parent 99311f7
commit 1076fa4
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/.dockerignore b/.dockerignore
@@ -26,20 +26,20 @@ submarine-workbench/
 submarine-workbench-v2/
 submarine.iml
 target/
-venv/
 webapps/
 website/
-.git/
-.idea/
-.github/
+**/.git/
+**/.idea/
+**/.github/
 
 # Allow files in pysubmarine
-!submarine-sdk/pysubmarine/*
+!submarine-sdk/pysubmarine/**
 # Allow files in pysubmarine
-!dev-support/docker-images/*
+!dev-support/docker-images/**
 
 # ignore python Distribution / packaging
 .Python
+**/venv/
 **/env/
 **/build/
 **/develop-eggs/
@@ -54,4 +54,4 @@ website/
 **/.mypy_cache/
 **/*.egg-info/
 **/.installed.cfg
-**/*.egg
+**/*.egg
diff --git a/dev-support/docker-images/jupyter-gpu/Dockerfile b/dev-support/docker-images/jupyter-gpu/Dockerfile
@@ -118,7 +118,7 @@ RUN wget --quiet https://repo.continuum.io/miniconda/Miniconda3-py311_${MINICOND
 
 # Install sumbarine python sdk and notebook
 RUN mkdir -p submarine/submarine-sdk/pysubmarine
-COPY submarine-sdk/pysubmarine/* submarine/submarine-sdk/pysubmarine
+COPY submarine-sdk/pysubmarine/ submarine/submarine-sdk/pysubmarine
 RUN pip --no-cache-dir install -e submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
     # Add DeepFM example into notebook
     cp submarine/submarine-sdk/pysubmarine/example/submarine_experiment_sdk.ipynb $HOME && \

diff --git a/dev-support/docker-images/jupyter-gpu/start-notebook.sh b/dev-support/docker-images/jupyter-gpu/start-notebook.sh
@@ -43,4 +43,4 @@ if [[ -n "${NB_PREFIX}" ]]; then
   NOTEBOOK_ARGS="--NotebookApp.base_url=${NB_PREFIX} ${NOTEBOOK_ARGS}"
 fi
 
-/bin/bash -c "jupyter notebook ${NOTEBOOK_ARGS}"
+/bin/bash -c "jupyter lab ${NOTEBOOK_ARGS}"
diff --git a/dev-support/docker-images/jupyter/Dockerfile b/dev-support/docker-images/jupyter/Dockerfile
@@ -118,8 +118,8 @@ RUN wget --quiet https://repo.continuum.io/miniconda/Miniconda3-py311_${MINICOND
 
 # Install sumbarine python sdk and notebook
 RUN mkdir -p submarine/submarine-sdk/pysubmarine
-COPY submarine-sdk/pysubmarine/* submarine/submarine-sdk/pysubmarine
-RUN pip --no-cache-dir install submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
+COPY submarine-sdk/pysubmarine/ submarine/submarine-sdk/pysubmarine
+RUN pip --no-cache-dir install -e submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
     # Add DeepFM example into notebook
     cp submarine/submarine-sdk/pysubmarine/example/submarine_experiment_sdk.ipynb $HOME && \
     cp -r submarine/submarine-sdk/pysubmarine/example/{data,deepfm_example.ipynb,deepfm.json} $HOME

diff --git a/dev-support/docker-images/jupyter/start-notebook.sh b/dev-support/docker-images/jupyter/start-notebook.sh
@@ -43,4 +43,4 @@ if [[ -n "${NB_PREFIX}" ]]; then
   NOTEBOOK_ARGS="--NotebookApp.base_url=${NB_PREFIX} ${NOTEBOOK_ARGS}"
 fi
 
-/bin/bash -c "jupyter notebook ${NOTEBOOK_ARGS}"
+/bin/bash -c "jupyter lab ${NOTEBOOK_ARGS}"