-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Upgrade pyarrow to 18.1.0 #31476
base: master
Are you sure you want to change the base?
chore(deps): Upgrade pyarrow to 18.1.0 #31476
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #31476 +/- ##
===========================================
+ Coverage 60.48% 83.75% +23.26%
===========================================
Files 1931 538 -1393
Lines 76236 39128 -37108
Branches 8568 0 -8568
===========================================
- Hits 46114 32772 -13342
+ Misses 28017 6356 -21661
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is a biiiig bump, fingers crossed this doesn't break anything. But I assume we should have adequate coverage to protect against these types of upgrade regressions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing to "Request changes" to update the dependency bounds.
Co-authored-by: Ville Brofeldt <[email protected]>
@villebro I've updated the dependency bounds |
Running CI 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update requirements/development.txt
, too, as that is pinning pyarrow==14.0.2
. Optimally, you should run the uv
commands for this.
Thanks, I've run the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - it appears the docker build step is failing, but I believe it's unrelated. I'll try to restart CI, but it may well be that something needs to be fixed on master before we can get this working..
SUMMARY
Upgrade pyarrow to 18.1.0, to support the StringView arrow type.
TESTING INSTRUCTIONS
Start Superset and verify that the SQL Lab queries are still working.
ADDITIONAL INFORMATION