-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: corrects spelling of USE_ANALAGOUS_COLORS to be USE_ANALOGOUS_COLORS #31774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
Category | Issue | Fix Detected |
---|---|---|
Undocumented Feature Flag ▹ view |
Files scanned
File Path | Reviewed |
---|---|
superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts | ✅ |
superset-frontend/packages/superset-ui-core/src/color/CategoricalColorScale.ts | ✅ |
superset/config.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-review
on this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-review
command in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-description
command in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolve
command in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ✅ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though it left it wondering what that flag does, it doesn't seem to be documented where I would expect.
Yep! I plan to open a PR that merges FEATURE_FLAGS.md into the config, bringing all the notes/sorting so we don't have to do double-entry bookkeeping any more. |
7390f28
to
305cd93
Compare
SUMMARY
5.0 breaking change. Fixes spelling called out previously in https://github.com/apache/superset/pull/27930/files by @zhangymPerson. The old PR got a bit outdated, so I spun up this new one and reworded the UPDATING entry a bit. Thanks for catching this!!!
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
Description by Korbit AI
What change is being made?
Fix the spelling error of the feature flag
USE_ANALAGOUS_COLORS
toUSE_ANALOGOUS_COLORS
across the codebase, documentation, and test cases.Why are these changes being made?
The spelling correction ensures consistency and accuracy in the naming of feature flags across the codebase, preventing potential confusion or errors for developers and users. Maintaining consistency in the naming convention enhances code readability and reliability.