[WiP] docs: plug the Hello World plugin #8333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
commented
Oct 2, 2019
| @@ -764,6 +764,11 @@ def query_obj(self): | |||
| return d | |||
|
|
|||
|
|
|||
| class HelloWorld(BaseViz): | |||
There was a problem hiding this comment.
For some reason this appears to be necessary despite being in useLegacyApi: false, also the content of buildQuery doesn't seem used at this time
There was a problem hiding this comment.
I just lost a lot of time coming to this realisation :(
There was a problem hiding this comment.
Me too. This is a really sad limitation, if only this wasn't required, adding visualisations could be much simpler and more isolated.
mistercrunch
force-pushed
the
hello_world_plugin
branch
from
f6865a7
to
77802bf
Compare
mistercrunch
force-pushed
the
hello_world_plugin
branch
from
77802bf
to
b6cc1c3
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a simple "hello world" plugin here: apache-superset/superset-ui-plugins#216, this is the Superset-side PR to get that plugin loaded up in Superset